Repository navigation
Conversation
This was referenced Oct 3, 2026
zzylol
marked this pull request as draft
October 3, 2026 19:29
Contributor
Author
|
Parked as draft: PR priorities changed (see #528). Order is now (A) finish #511 operator sharing, (B) the #572 crate/module reorganization, (C) #509 end-to-end stages. This PR sits on the old |
This was referenced Oct 4, 2026
Contributor
Author
|
Ported onto the current stack in #598 |
zzylol
added a commit
that referenced
this pull request
Oct 4, 2026
Port of the parked #562 and #564 for #509 Example 2. The SQL frontend names `SQRT(SUM(c*c))` over Float64 grouped unit counts as FrequencyL2, and `-SUM(p*LN(p))` with `p = COUNT(*)*1.0 / SUM(COUNT(*)) OVER ()` as FrequencyEntropy converted to nats. An exact population count guards SQL's empty-input NULL. Integer products, nullable keys, filters, HAVING, other log bases and partial windows are refused. The rules are the old Pass 1 SemanticEquivalentRewriteStrategy rules, run by lower_sql at the query root so the Stage 1 pipeline sees the intents; the exact candidate is the native exact reducer. The executor gains SQL sqrt (from #562). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closing: this parked chain (on |
zzylol
added a commit
that referenced
this pull request
Oct 15, 2026
#509 Example 2 writes L2(src_ip) and Entropy(src_ip) as SQL idioms over grouped unit counts. The SQL lowering (single query and batch) now names them at the query root as FrequencyL2 / FrequencyEntropy aggregates carrying the query's accuracy target, so Pass 1 offers exact and summary candidates for each: - L2: SQRT(SUM(c * c)) over COUNT(*) per key, only when the product is already Float64 (CAST(c AS DOUBLE) factors or CAST(COUNT(*) AS DOUBLE)). The Int64 product stays relational: SQL integer overflow is observable. - Entropy: -SUM(p * LN(p)) with p = COUNT(*)[*1.0] / SUM(COUNT(*)) OVER () over the complete unordered frame; the IR's bits are converted to nats and SQL's -0.0 is kept. Both require a single non-nullable Bool/Int64/Utf8 key, no HAVING and no measure filter, follow projections only, keep the original output schema, and decide SQL's empty-input NULL by an exact population count joined beside the statistic, never by an estimate. Scaled probabilities, LOG2, partitioned or ordered windows and nullable keys stay relational. Ports the frontend part of #598 (originally #562 and #564).
zzylol
added a commit
that referenced
this pull request
Oct 15, 2026
#509 Example 2 writes L2(src_ip) and Entropy(src_ip) as SQL idioms over grouped unit counts. The SQL lowering (single query and batch) now names them at the query root as FrequencyL2 / FrequencyEntropy aggregates carrying the query's accuracy target, so Pass 1 offers exact and summary candidates for each: - L2: SQRT(SUM(c * c)) over COUNT(*) per key, only when the product is already Float64 (CAST(c AS DOUBLE) factors or CAST(COUNT(*) AS DOUBLE)). The Int64 product stays relational: SQL integer overflow is observable. - Entropy: -SUM(p * LN(p)) with p = COUNT(*)[*1.0] / SUM(COUNT(*)) OVER () over the complete unordered frame; the IR's bits are converted to nats and SQL's -0.0 is kept. Both require a single non-nullable Bool/Int64/Utf8 key, no HAVING and no measure filter, follow projections only, keep the original output schema, and decide SQL's empty-input NULL by an exact population count joined beside the statistic, never by an estimate. Scaled probabilities, LOG2, partitioned or ordered windows and nullable keys stay relational. Ports the frontend part of #598 (originally #562 and #564).
zzylol
added a commit
that referenced
this pull request
Oct 15, 2026
…and UnivMon frequency statistics (#707) feat(types): summary-capability facts in the family-capability table Each family lists the readouts one of its states answers (Readout: total, item frequency, any quantile rank, distinct count, L2, entropy, top-k), so a planner rule can check that one state serves every consumer's statistic: UnivMon answers its total and every frequency moment, KLL every rank, CountSketch item frequencies and L2, the heap sketches top-k and item frequencies. Exact accumulators are read as finalized values and answer no readout. feat(logical-asap-optimization): Pass 2 summary-capability rule Composition sizes each consumer's summary build alone, for its own target. The summary-capability rule groups the builds of one candidate that chose the same family over the same input sub-DAG (window, WHERE and time range included), item and weight, grouping and filter, whose every reader is an estimate the family answers (the family-capability table's readouts), and that differ only in size. For every choice, per group, of no sharing or one subset of two or more members whose sizes differ (partial sharing included), the subset becomes one build sized with each parameter's largest value among the members (a KLL's failure probability and DDSketch's alpha: the smallest), and every guarantee above it is composed again, so plan selection checks each consumer against the shared state. Builds of equal size stay the identical-expression rule's; unshared builds are untouched and no consumer changes family. Stage 1 lists each composed candidate, its identical-expression candidates, then each summary-capability candidate followed by its own identical-expression candidates, every distinct DAG once. The Pass 2 record (Pass2Candidate) names the shared summaries ("UnivMon for Q1, Q3") and the shared identical groups. Example 2 (PromQL stand-in): with #702's sizing the three UnivMons differ (Q1 a distinct-count heap on 19 layers, Q2 the baseline shape for entropy, Q3 a one-layer Count Sketch for L2), so the rule offers one UnivMon for each pair and one for all three, each sized with the members' largest heap, rows, columns and layers and the smallest recorded distinct-count failure probability; the third query keeps its own options. A shared UnivMon whose rows and columns together exceed asap_sketchlib's hash budget (rows * (ceil(log2 cols) + 1) <= 128) is not offered, since the library would not build it. The shared UnivMon stays one build in Stage 2. feat(frontend-sql): recognize the SQL frequency L2 and entropy idioms #509 Example 2 writes L2(src_ip) and Entropy(src_ip) as SQL idioms over grouped unit counts. The SQL lowering (single query and batch) now names them at the query root as FrequencyL2 / FrequencyEntropy aggregates carrying the query's accuracy target, so Pass 1 offers exact and summary candidates for each: - L2: SQRT(SUM(c * c)) over COUNT(*) per key, only when the product is already Float64 (CAST(c AS DOUBLE) factors or CAST(COUNT(*) AS DOUBLE)). The Int64 product stays relational: SQL integer overflow is observable. - Entropy: -SUM(p * LN(p)) with p = COUNT(*)[*1.0] / SUM(COUNT(*)) OVER () over the complete unordered frame; the IR's bits are converted to nats and SQL's -0.0 is kept. Both require a single non-nullable Bool/Int64/Utf8 key, no HAVING and no measure filter, follow projections only, keep the original output schema, and decide SQL's empty-input NULL by an exact population count joined beside the statistic, never by an estimate. Scaled probabilities, LOG2, partitioned or ordered windows and nullable keys stay relational. Ports the frontend part of #598 (originally #562 and #564). feat(physical-operators): exact distinct, L2 and entropy reducers Exact Cardinality, FrequencyL2 and FrequencyEntropy aggregates had no native implementation, so the exact option of #509 Example 2's three statistics could not execute. - Reduction::Cardinality(cols) counts distinct tuples; a tuple with any NULL is skipped, and grouped key encoding keeps tuple boundaries and folds signed zero and NaN payloads. - Reduction::FrequencyL2(col) and FrequencyEntropy(col) count the unit frequencies of one Bool/Int64/Float64/Utf8 identity column: NULL is skipped, a non-finite float is an error, an empty population gives 0.0, and entropy is in bits, as AggIntent::FrequencyEntropy and UnivMon's readout define it. - The dictionaries are memory-accounted and cooperative. - Logical aggregates bind them: grouped ones (SQL COUNT(DISTINCT)) and per-series range reductions (distinct_over_time, l2_over_time, entropy_over_time), which reduce each series' window samples, restore the run's timestamp and drop the metric name as range functions do. - The analytical cost lowering prices them as hash aggregates. Ports the exact-reducer part of #597 (from #559 and #563). feat(physical-operators): native UnivMon state over typed identities UnivMon had a kernel but no native DAG state: a build was rejected ("summary family has no native DAG state implementation"), a summary build accepted only Float64 samples, and Pass 1's UnivMon update (each value of the item column one unit occurrence) did not bind, so no UnivMon candidate of #509 Example 2 could execute. - UnivMon is a native family; its states validate against their parameters, and one state answers its total, distinct count, L2 norm and entropy. - A UnivMon build takes Bool, Int64 and Utf8 identities as type-tagged key bytes (Int64 above 2^53 stays distinct) besides Float64 samples; NULL is skipped. Retained heap key bytes count toward state memory. - A unit-frequency update over one item column binds, for UnivMon and HLL, as a value-frequency build over that column: grouped (SQL src_ip) and per series (PromQL sample values). Ports the UnivMon part of #597 (from #557). test(integration-tests): Example 2 in SQL; the recognized idioms execute Example 2's SQL Q3 casts its counts to DOUBLE (the design's Int64 SUM(c * c) can overflow and stays relational), and the SQL Q2 and Q3 now lower to the entropy and L2 intents, so the SQL workload has the PromQL stand-in's Pass 1 options. The recognized entropy executes in nats with SQL's -0.0, L2 executes exactly, and both give NULL on empty input, decided by the exact population count. feat(devtools): stage_pipeline example planner-layering-2 stage_pipeline plans #509 Example 2: three SQL dashboard panels over the last minute of flows (distinct sources at eps 0.02, entropy at 0.05, L2 at 0.01, delta 0.01), lowered over its flows(ts, src_ip) table. SQL workloads lower every entry, batch and repeating, each with its own accuracy target (lower_sql_batch read only batch entries). The stage-viewer tab 2 row is regenerated from it: 82 plans, 16 from Pass 1, the rest from the identical-expression and summary-capability rules (one UnivMon for each pair of queries and for all three); 6 valid, P1 (all exact) selected at 6.08 per second. The row previously said 8 plans were valid. feat(logical-asap-optimization): guarantees through a join beside exact inputs and an exactly decided CASE SQL Example 2's L2 decides the empty-input NULL from an exact population count cross-joined beside the estimate and a CASE on that count. No guarantee rule covered the join or the CASE, so every SQL plan with UnivMon for Q3 was rejected ("the output has no guarantee"), although the L2 estimate is certified. - A join (inner, outer or cross) whose inputs are exact but one keeps that input's guarantee when its predicate reads only exact columns: which rows match, and how often, then does not depend on an estimate. A key on the approximate input's columns, a semi- or anti-join, or two approximate inputs have none. - A CASE whose operand and conditions are exact keeps its weakest branch's guarantee; a literal or NULL branch, or a missing ELSE, is exact. A condition over an approximate value has none. - A projection over such a join composes each output column this way. Guarantees are per node, so every column of the approximate input counts as approximate; column-level tracking (#689) stays the general solution. A root's default metric (#690) looks through the same shape: a projection whose CASE value branches read columns (or literals, cast or not) takes those columns' metric, following them through joins and row-preserving operators to an aggregate's measure, so SQL's L2 root resolves to a relative target as the PromQL one does. Any other expression stays absolute. docs(stage-viewer): regenerate the Example 2 row with SQL L2 through UnivMon With the join and CASE guarantee rules, the SQL Q3 UnivMon plans are valid: 12 of the 82 plans are valid (Q3 exact or UnivMon), 70 invalid (Q1 HLL or UnivMon without a distinct bound, Q2 UnivMon without an entropy bound). P1 (all exact) is still selected at 6.08 per second; UnivMon on Q3 costs 8.08. fix(physical-operators): charge UnivMon key memory without walking its heaps A build charges a state's memory after every input row, and UnivMon's charge summed the bytes of every key on every layer's heap, so building was quadratic in the heap: a 20,000-key heap on 19 layers over 40,000 keys took 3.3 s in release. The charge now bounds the retained keys by every heap slot holding the longest key seen (tracked on insert, merge and adoption of a decoded sketch), in constant time. A test checks that the charge does not grow with heap occupancy; a timing test (ignored, release) checks the large build. fix(logical-asap-optimization): summary-capability review fixes - A capability group of more than 63 builds is an error: one 64-bit mask enumerates the subsets of at most 63, and the shift was clamped, so a larger group was enumerated wrongly (and took 2^63 steps) instead of refused. - A summary-capability variant whose guarantee composition fails carries its own error, so Stage 1 lists it as a candidate that cannot be composed and keeps the remaining variants; one failure used to drop them all. - shared_size_params no longer claims every sizing bound is monotone (a Count Sketch's collision bound is tighter at a power-of-two width than one column wider); the shared state is checked by composing every guarantee above it again. fix(logical-asap-optimization): read each column's guarantee in a projection over a join A projection's guarantee assumed the error lies only in its child's sample-value column (the column named "value", or the only numeric one). Over a join that column can be an exact input's, so the approximate input's columns were read as exact: projecting sum(m) * 1000 beside the exact side's value composed to the approximate side's absolute error 1, while the truth is 1000. A projection over a join (directly, or through projections, filters, sorts, limits or deduplication) now reads each column's own guarantee (column_guarantees), and a projection over a computed projection over a join, whose columns' guarantees are unknown, has none. Plan selection's operand-domain lookup reads columns the same way. column_guarantees and join_guarantee document their assumption that every approximate node of Stage 1 has an exact row set. Per-column tracking in general is #689. fix(logical-asap-optimization): refuse summary-capability groups of more than 20 builds Every subset of two or more builds of a group is a candidate, 2^n of them; past 20 builds (about a million) the rule returns an error naming the limit instead of enumerating. fix(physical-operators): bound UnivMon key memory by the key bytes inserted Charging every heap slot at the longest key seen overcounts badly: one 1 KB key in a sketch of 19 layers of 20,000 slots was charged 380 MB. Each layer's heap keeps at most one copy of a key, so the retained keys are also bounded by the layers times the bytes of every key inserted (or merged in); the charge takes the smaller bound, still in constant time. asap_sketchlib exposes no eviction hook for an exact running total.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: SQL
SQRT(SUM(c*c))over grouped counts is never seen asL2(x)#509 §Example 2 writes Q3 as an SQL idiom and states the gap directly:
#509 §Pass 1 (local candidate generation) says Pass 1 "identifies its computation semantics, applies rewrite rules, and generates every candidate", and §Assumptions 1 says the rewrite rules are given by developers. Without a rule that names the computation
L2(src_ip), none of theL2(x)candidates (exact L2, norm summary, UnivMon) and none of the Example 2 sharing can start.Before this PR, the lowered SQL is only relational:
No node carries
AggIntent::FrequencyL2, soSemanticEquivalentRewriteStrategyoffers nothing. In addition, the native expression compiler rejects the SQL function namesqrt(onlypromql_sqrtis known), so the original exact SQL could not execute natively either.Scope. This PR adds one conservative Pass 1 rewrite rule for the floating-point form of the L2 idiom, and native SQL
sqrt. It does not recognize the uncast integer form above, which is exactly #509's Q3 text: SQL Int64c * ccan overflow, and that behavior cannot be dropped. It also leaves out the Q2 entropy idiom (#564), the Pass 2 sharing rule, and UnivMon L2 accuracy.Proposed method
The rule runs in logical ASAP-aware optimization, Pass 1, as part of the existing
SemanticEquivalentRewriteStrategy. It is implemented inasap-aware-mappingover the resolved operator graph, not inside the SQL frontend.Match (
frequency_l2_rewrite(root)), each step must hold or the rule returnsNone:rootis aProjectwith exactly one output.Projectnodes downward, substituting column references by the projected expressions (positional lineage). OnlyColumn, Float64Cast(try_cast: false),ArithmeticandFunctionCallare substituted. Crossing aFilterorLimithere is not allowed, since that would change the population.sqrt(arg)(case-insensitive) with one argument, andarg(after removing Float64 casts) is column 0 of the next node.Aggregate { reduction: Reduce(keys), having: None }with no grouping keys, notwithout, no measure filters, and exactly one measureSum { col: Some(col) }.colthrough projections givesleft * rightwithExprSemantics::Sql, and its type is alreadyFloat64. An Int64 product is refused.Aggregate { reduction: Reduce(keys), having: None }with exactly one key, notwithout, no measure filters, and exactly one measureCount { accuracy }. Bothleftandright(after removing Float64 casts) are column 1, i.e. the count.Bool,Int64orUtf8. A nullable key is refused becauseCOUNT(*) GROUP BYmakes a real NULL group, while the frequency intent skips NULL.Rewrite. Build
L2 is positive for any non-empty unit-count population, so
0.0only happens for an empty one. TheCASErestores SQL'sNULLforSUMover no groups without another count. The rewrite is returned only if its schema equals the original root's schema.Candidate.
SemanticEquivalentRewriteStrategy::matchesandreplacementscall the rule first. The replacement hasprovenance: LogicalRewrite. The original exact SQL DAG stays in the search as its own candidate.Native SQL
sqrt. The expression compiler'svalidateacceptssqrt(case-insensitive) with oneInt64,Float64orNullargument.evaluatereturnsNullforNull, andFloat64(x.sqrt())for Float64 or Int64 input. A negative input gives NaN, asf64::sqrtdoes.Key code interfaces
crates/asap-aware-mapping/src/frequency_rewrite.rs(new private module)crates/asap-aware-mapping/src/rewrite.rsIntent produced (existing,
crates/types/src/pre_asap/agg_intent.rs):Native expression support in
crates/asap-physical-operators/src/expressions/planner.rsis inside the privateevaluate/validatefunctions; no public signature changes.Usage (
crates/frontend-sql/tests/frequency_l2.rs):Fields
frequency_l2_rewriteroot&Rc<OperatorNode>Project.Option<Rc<OperatorNode>>Some(rewritten)with a schema equal toroot.schema, orNoneif any match step fails.Helpers
expand(expr, node)Projectnodes fromnode, substitutingexpr's columns. Returns the expanded expression and the first non-Projectnode.substitute(expr, cols)Column(i)withcols[i].expr. Supports Float64 non-tryCast,Arithmetic,FunctionCall; anything else →None.uncast(expr)Cast { to: Float64, try_cast: false }.FrequencyL2as built by the rulecolSome(key): the single grouping key index of the inner aggregate, relative to its child.accuracyCount { accuracy }target, unchanged. No default is invented.Rewritten nodes
AggregatereductionReduce(GroupKeys::none())measures/output_names[FrequencyL2 {..}]/["frequency_l2"]filters/having[]/NonechildWHEREpredicates are kept.Projectaliasnorm).exprCASE WHEN col0 = 0.0 THEN CAST(NULL AS Float64) ELSE col0 END,ExprSemantics::Sql.qualifierReplacementSubDAG:strategynames the strategy;replacementis the new sub-DAG;provenance = LogicalRewritemarks a logical rewrite, not a summary realization;rationaleis the text above.SQL
sqrt: one argument of typeInt64,Float64orNull; resultFloat64orNull.Examples
End to end (
crates/integration-tests/tests/sql_frequency_l2.rs::sql_l2_original_and_rewrite_execute_equivalently).The rule returns a
ProjectoverFrequencyL2(src_ip)over the filtered scan. Both the original and the rewrite are compiled to the wire format and executed against a raw in-memory connector:(src_ip, keep)NULLNULL(discard, false)NULLNULL(a,true),(a,true),(b,true),(discard,false)Recognized vs declined (
crates/frontend-sql/tests/frequency_l2.rs)src_ipnullableSUM(CAST(c AS DOUBLE)*CAST(c AS DOUBLE)),COUNT(*) AS c … WHERE keepFrequencyL2candidate; schema equal to originalSUM(c * c),CAST(COUNT(*) AS DOUBLE) AS cFrequencyL2candidateSUM(c*c),COUNT(*) AS c(Int64 product, #509 Q3 text)SUM(CAST(c AS DOUBLE)*CAST(c AS DOUBLE))… GROUP BY src_ip HAVING COUNT(*) > 1CAST(SUM(CAST(keep AS BIGINT)) AS DOUBLE) AS cOther tests in the same file:
frequency_l2_preserves_accuracy_target: withEpsilonDelta { epsilon: 0.01, delta: 0.01 }, the new intent carries that same target.default_search_keeps_exact_sql_and_frequency_alternatives:search_workload_with_targetswithdefault_strategies()yields an inventory that contains both a candidate withFrequencyL2and one without.SQL
sqrt(crates/asap-physical-operators/tests/physical_semantics.rs::sql_sqrt_executes_numeric_and_null_arguments):sqrt(Int64 9) = 3.0,sqrt(Float64 2.25) = 1.5,sqrt(NULL) = NULL,sqrt(-1.0)is NaN.Out of scope
c * cform from docs: propose workload-wide planning, summary sharing, and materialization #509 Q3.The status note
docs/develop_docs/planner-layering-status.mdgains §"SQL L2 follow-up acceptance" describing the same limits.Stack and validation
Stacked on #559 · Next: #563 · Reference/tracker: #528
Validation: recognition regression fails on the parent; four frontend tests cover recognition, refusal boundaries, accuracy and inventory retention; end-to-end comparison covers filtered data and empty input; native scalar tests; existing rewrite tests; formatting and affected all-target Clippy with warnings denied.